-
Notifications
You must be signed in to change notification settings - Fork 40
feat(queries): Add 'Select All' and 'Invert Selection' buttons to the Query Builder #7679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Triggered by 0cfc311 on branch refs/heads/issue-7485
Triggered by 9c4fd45 on branch refs/heads/issue-7485
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- click the newly added select all button, see if all results are selected
- Select some records, then click invert selection, make sure all records but the ones previously checked are selected
- Select no records, then click invert selection, make sure the invert selection button is properly inverting the current selection.
- Perform these check on at least one large database ( queries with more than 50,000 or 100,000+ results), also keep track of any latency longer than 10 seconds when using both invert selection and select all.
- (optional) perform this test on a database with at least 500,000+ query results), this is an optional stress test so feel free to use a larger DB if you're able to
Looks wise everything seems to be selected; however, I am running into this issue sometimes where it shows all results are selected but when I create a record set, not all records are added. I also checked the behavior against main (same query and selected no results) and all results are added. This does not seem to always happen but I can consistently recreate it with this query: https://ojsmnh20251211-issue-7485.test.specifysystems.org/specify/query/305/
Selecting all records individually:
02-09_12.39.mp4
Using 'Select All' button:
02-09_12.40.mp4
I also ran into it when creating a CSV for that query and others. It seems to consistently cut off at either 80 or 120 records depending on the query, I'm not sure why. Here's another example query from a different DB: https://herbrbge20260105-issue-7485.test.specifysystems.org/specify/query/554/
Fixes #7485
This Pr adds 2 new buttons to query builder results, select all and Invert Selection. These only appear after a query has been saved and have also been given a limit to only appear on queries with < 3 million results.
Sample demonstration
Screen.Recording.2026-02-09.at.11.04.02.AM.mov
Checklist
self-explanatory (or properly documented)
Testing instructions